Add caching to DefaultTypeResolver (issue #437) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeesch
reviewed
Oct 9, 2023
| $"{messageType.FullName}, {messageType.Assembly.GetName().Name}"); | ||
| string messageTypeName = ProduceTypeCache.GetOrAdd( | ||
| messageType, | ||
| static messageType => $"{messageType.FullName}, {messageType.Assembly.GetName().Name}"); |
There was a problem hiding this comment.
I see benefits in using a Type cache on message consumption to avoid the Type.GetType call. But when producing I don't know if we will have a performance benefit changing from a string concatenation to a dictionary search.
There was a problem hiding this comment.
I think when producing there will be no performance benefit but rather a memory allocations benfit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a cache to
DefaultTypeResolverFixes #437
How Has This Been Tested?
Run all tests defined in the project
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement